Bug with partner robbery system

[ada]

Where does the bug appear: server
When did the bug appear: As soon as partner robberies were implemented?
Describe the bug:
Partner robbery systems do not clear the partner flag correctly. Logic works on the assumption that the partner is someone that is valid to rob stuff, but that's not necessarily true. The /partner command does the check properly for law enforcement, but it does not account for when the player switches skill.
Frequency: always
Severity: major
Steps to reproduce:
- Spawn as a valid robber (civilian)
- Pick another valid robber as a partner
- /kill and turn into a cop or otherwise "non-valid" robber
- (the system doesn't reset your robbery partner, still treats it as valid)
- go to a shop and have your partner aim a weapon
- robbery will succeed, you will be blindly added the wanted level but you are still flagged as a cop so you cannot be arrested.

This may be an issue in other features/systems as well that rely on valid flags being set - not enough to just check on the command itself, you need to check for all ways where that validity state can be affected (death, switching class, jail, etc).

[Osolnik]

This has been fixed. It will be live on server soon.
Thank you for the report.